-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laying more foundation #5205
Laying more foundation #5205
Conversation
b7c4201
to
ed1fcc4
Compare
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
@@ -525,6 +525,9 @@ const startTest = async () => { | |||
readyToTest.value = true; | |||
// TODO: @brit - currently test does not create a changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@britmyerss TODO as we were discussing for when we get there!
71ca279
to
60caf0b
Compare
bfc1417
to
b6bff58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all cases that force a change-set and it feels way more smooth than it was before this change
b6bff58
to
72eb3c1
Compare
Looking to resolve a few fundamental problems:
HEAD
the API call promises return to components that have been unmounted, which is destined to failHEAD
that creates a new change set.router.push
/router.replace
is called, the vue router believes thecurrentRoute
is the "original" (what is still in the URL bar), so subsequent router actions are almost always wrong which put the user right back to where they came from.HEAD
, the WsEvent topics were correctly using the newchangeSetId
, however no stores were subscribed to receive them yetWith these changes:
router.currentRoute
, we store the "intended" URL inrouterStore.currentRoute
setSelected...
orselect...
should not run inonActivated
component_attribute.store
)onBeforeMount
of the appropriate componentrouter.push
/router.replace
when their change set is not the selected change setawait
API responses in components and callsetSelected...
orselect...
setSelected...
orselect...
when the actor is the current usersetSelected...
orselect...
based on which API (like mgmt function) caused the event.We shouldn't have to think about handling the "happy case" when in a change set, vs the "hard" case of "on head". Now, we don't have to await and check for HTTP 200, we just check the user in the WsEvent (and we don't lose any WsEvents).